emit SetQueue on track changes (load/next/prev)#3
Open
vitbashy wants to merge 1 commit intoralph:emit-set-queue-eventfrom
Open
emit SetQueue on track changes (load/next/prev)#3vitbashy wants to merge 1 commit intoralph:emit-set-queue-eventfrom
vitbashy wants to merge 1 commit intoralph:emit-set-queue-eventfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emit SetQueue event when tracks change so queue UI stays in sync
previously,
SetQueuewas only emitted inhandle_next_context()which doesn't cover all track change scenarios. This caused queue counters to show stale data (e.g., staying at "1/15" when skipping to track 2)this adds
emit_set_queue_event()calls to:handle_load()- after context loadshandle_next()- after advancing to next trackhandle_prev()- after going to previous track